Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated assets and phishing controller packages #17569

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Feb 2, 2023

This PR is to update the controllers that are updated in Release 40.0.0 in the core repo.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in the browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@socket-security
Copy link

socket-security bot commented Feb 2, 2023

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@NidhiKJha
Copy link
Member Author

@SocketSecurity ignore [email protected] [email protected]

@NidhiKJha NidhiKJha marked this pull request as ready for review February 2, 2023 15:09
@NidhiKJha NidhiKJha requested a review from a team as a code owner February 2, 2023 15:09
@NidhiKJha NidhiKJha requested a review from adonesky1 February 2, 2023 15:09
@NidhiKJha NidhiKJha requested a review from Gudahtt February 2, 2023 15:10
@metamaskbot
Copy link
Collaborator

Builds ready [bdfecf0]
Page Load Metrics (1468 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint972251302813
domContentLoaded103920331418320154
load103920331468341164
domInteractive103920331418320154
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10494 bytes
  • ui: 0 bytes
  • common: 38317 bytes

@NidhiKJha NidhiKJha merged commit 080d72a into develop Feb 6, 2023
@NidhiKJha NidhiKJha deleted the update-core-release40 branch February 6, 2023 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants