Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17439 - Prevent event error when user presses enter key during onboarding #17497

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

Screenshots/Screencaps

Provided in the issue

Manual Testing Steps

Provided in the issue

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner January 30, 2023 20:03
@darkwing darkwing requested a review from hmalik88 January 30, 2023 20:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [68ed570]
Page Load Metrics (1366 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101164124189
domContentLoaded102718521339246118
load102719341366248119
domInteractive102718521339246118
Bundle size diffs
  • background: 0 bytes
  • ui: 9 bytes
  • common: 0 bytes

Copy link
Contributor

@PeterYinusa PeterYinusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit 6439d03 into develop Jan 31, 2023
@darkwing darkwing deleted the 17439-prevent-default-error branch January 31, 2023 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'preventDefault')
6 participants