Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview icons for buy, send, and swap #17492

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Conversation

darkwing
Copy link
Contributor

Explanation

This PR updates the buy, send, and swap icons to the new icons provided by the design system team

Screenshots/Screencaps

NewHomeIcons

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested review from a team and kumavis as code owners January 30, 2023 15:15
@darkwing darkwing requested a review from PeterYinusa January 30, 2023 15:15
@darkwing darkwing marked this pull request as draft January 30, 2023 15:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the overview-icon-updates branch from 38be978 to c8b338e Compare January 30, 2023 21:06
@darkwing darkwing force-pushed the overview-icon-updates branch from c8b338e to 8d3a52f Compare January 30, 2023 21:18
@metamaskbot
Copy link
Collaborator

Builds ready [8d3a52f]
Page Load Metrics (1452 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1062901494722
domContentLoaded104719001424245118
load104719001452238114
domInteractive104719001424245118
Bundle size diffs
  • background: 0 bytes
  • ui: -5022 bytes
  • common: 0 bytes

@darkwing darkwing marked this pull request as ready for review January 30, 2023 21:46
@darkwing darkwing merged commit 18a1beb into develop Jan 31, 2023
@darkwing darkwing deleted the overview-icon-updates branch January 31, 2023 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants