Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons: Replace instance of fa-qr-code icon #17474

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

darkwing
Copy link
Contributor

Explanation

This is the last place where the old QR image is used:

qr-code.mp4

Manual Testing Steps

  1. Enter send flow
  2. Play around with the send input

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner January 27, 2023 18:38
@darkwing darkwing requested a review from montelaidev January 27, 2023 18:38
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [582cabc]
Page Load Metrics (1275 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99161123178
domContentLoaded100317151246226108
load100318531275242116
domInteractive100317151246226108
Bundle size diffs
  • background: 0 bytes
  • ui: 266 bytes
  • common: 0 bytes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested locally. One suggestion relating to accessibility

@metamaskbot
Copy link
Collaborator

Builds ready [3458923]
Page Load Metrics (1304 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint102161123178
domContentLoaded10331710127520297
load10561710130420699
domInteractive10331710127520297
Bundle size diffs
  • background: 0 bytes
  • ui: 270 bytes
  • common: 0 bytes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@darkwing darkwing merged commit d057410 into develop Jan 31, 2023
@darkwing darkwing deleted the new-icons-qrcode branch January 31, 2023 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants