Added metric Phishing Page Displayed for phishing warning page #17462

aleksandar-mihajlovic · 2023-01-27T12:27:43Z

Explanation

Added metric Phishing Page Displayed for phishing warning page, that occurs whenever user triggers phishing warning page.

Fixes Improve our phishing warning page Metrics #17453

Screenshots/Screencaps

Manual Testing Steps

Build project and run mock segment
Login to extension
Go to one of the untrusted sites: primalfrens.club, geishateahouse.io, cryptocity.fun
Phising page is opened
Check in console where the mock segment is, Phising Page Displayed metric is shown

github-actions · 2023-01-27T12:28:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-01-27T12:49:19Z

Builds ready [5403c2c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1179 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	222	120	30	14
		domContentLoaded	988	1666	1161	199	95
		load	988	1690	1179	207	99
		domInteractive	988	1666	1161	199	95

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

codecov-commenter · 2023-01-27T12:50:31Z

Codecov Report

Merging #17462 (5403c2c) into develop (30520a3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           develop   #17462   +/-   ##
========================================
  Coverage    59.86%   59.86%           
========================================
  Files          938      938           
  Lines        35861    35862    +1     
  Branches      9225     9225           
========================================
+ Hits         21467    21468    +1     
  Misses       14394    14394

Impacted Files	Coverage Δ
app/scripts/metamask-controller.js	`60.51% <0.00%> (+0.03%)`	⬆️
shared/constants/metametrics.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dzfjz · 2023-01-30T10:15:31Z

Verified by QA

metamaskbot · 2023-01-30T11:13:17Z

Builds ready [e116494]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1140 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	139	109	14	7
		domContentLoaded	910	1475	1130	195	93
		load	911	1508	1140	199	96
		domInteractive	910	1475	1130	195	93

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

metamaskbot · 2023-01-30T14:43:15Z

Builds ready [a6f86fa]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1545 ± 130 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	182	141	23	11
		domContentLoaded	1095	1932	1513	263	126
		load	1095	1965	1545	271	130
		domInteractive	1095	1932	1512	263	126

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

metamaskbot · 2023-02-02T11:06:03Z

Builds ready [2345646]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1355 ± 114 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	160	126	16	8
		domContentLoaded	1016	1765	1321	244	117
		load	1016	1880	1355	237	114
		domInteractive	1016	1765	1321	244	117

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

metamaskbot · 2023-02-02T12:55:18Z

Builds ready [b3bd332]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1356 ± 116 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	102	176	128	24	11
		domContentLoaded	961	1682	1329	225	108
		load	961	1686	1356	243	116
		domInteractive	961	1682	1329	225	108

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

metamaskbot · 2023-02-03T09:07:02Z

Builds ready [7197799]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1235 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	268	126	47	22
		domContentLoaded	985	1645	1207	220	106
		load	986	1645	1235	219	105
		domInteractive	985	1645	1207	220	106

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

metamaskbot · 2023-02-06T10:28:21Z

Builds ready [72dad73]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1579 ± 158 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	108	272	155	38	18
		domContentLoaded	1067	2286	1573	331	159
		load	1067	2286	1579	329	158
		domInteractive	1067	2286	1573	331	159

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 141 bytes
ui: 0 bytes
common: 70 bytes

Added metric Phishing Page Displayed for phishing warning page

5403c2c

aleksandar-mihajlovic marked this pull request as ready for review January 30, 2023 10:48

aleksandar-mihajlovic requested a review from a team as a code owner January 30, 2023 10:48

aleksandar-mihajlovic requested a review from ryanml January 30, 2023 10:48

Merge branch 'develop' into phishing-warning-metrics

e116494

Merge branch 'develop' into phishing-warning-metrics

a6f86fa

Merge branch 'develop' into phishing-warning-metrics

2345646

Merge branch 'develop' into phishing-warning-metrics

b3bd332

Merge branch 'develop' into phishing-warning-metrics

7197799

pedronfigueiredo approved these changes Feb 3, 2023

View reviewed changes

Merge branch 'develop' into phishing-warning-metrics

72dad73

jpuri approved these changes Feb 6, 2023

View reviewed changes

brad-decker merged commit d63014a into develop Feb 6, 2023

brad-decker deleted the phishing-warning-metrics branch February 6, 2023 17:06

github-actions bot locked and limited conversation to collaborators Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added metric Phishing Page Displayed for phishing warning page #17462

Added metric Phishing Page Displayed for phishing warning page #17462

aleksandar-mihajlovic commented Jan 27, 2023 •

edited

Loading

github-actions bot commented Jan 27, 2023

metamaskbot commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023

dzfjz commented Jan 30, 2023

metamaskbot commented Jan 30, 2023

metamaskbot commented Jan 30, 2023

metamaskbot commented Feb 2, 2023

metamaskbot commented Feb 2, 2023

metamaskbot commented Feb 3, 2023

metamaskbot commented Feb 6, 2023

Added metric Phishing Page Displayed for phishing warning page #17462

Added metric Phishing Page Displayed for phishing warning page #17462

Conversation

aleksandar-mihajlovic commented Jan 27, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Manual Testing Steps

github-actions bot commented Jan 27, 2023

metamaskbot commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023

Codecov Report

dzfjz commented Jan 30, 2023

metamaskbot commented Jan 30, 2023

metamaskbot commented Jan 30, 2023

metamaskbot commented Feb 2, 2023

metamaskbot commented Feb 2, 2023

metamaskbot commented Feb 3, 2023

metamaskbot commented Feb 6, 2023

aleksandar-mihajlovic commented Jan 27, 2023 •

edited

Loading