Fix getFullTxData so that customTxParamsData is not lost #16805
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -851,7 +851,7 @@ export const getFullTxData = createDeepEqualSelector( | |||
| return getTransaction(state, transactionId); | |||
| }, | |||
| (_state, _transactionId, _status, customTxParamsData) => customTxParamsData, | |||
| (txData, transaction, _status, customTxParamsData) => { | |||
There was a problem hiding this comment.
this looks right to me when I step through the code while running the example.
I think I was (and maybe still am a bit confused by input vs. output selectors that are passed to the createSelector function as described in the reduxToolkit docs.
@brad-decker are you able to elucidate this pattern a bit better for me?
There was a problem hiding this comment.
Is the last arg passed always the output selector? And then you pass as many input selector before that as there are args? That doesn't seem to match what we have here... I think I'm overcomplicating this.
There was a problem hiding this comment.
yeah, the last arg passed is the output selector, and each of its params is the return value of the previous selectors
There was a problem hiding this comment.
One second while I look up what 'elucidate' means
There was a problem hiding this comment.
There are 3 selectors being used in this 'createDeepEqualSelector', 'getTxData', and two inline functions. The fourth argument gets txData from 'getTxData', transaction from the first inline function, and customTxParamsData from the second inline function
There was a problem hiding this comment.
ahhh I see now! Ok feels confusing because the status arg is used in one of the input selectors but not the output selector.
Fixes #16798 (comment)
This bug was introduced here 4245f24#diff-45ae84764c1d49a07813a91adc3351d6ed96bf9ee8fa2ae4c9a116d1e0cba06cR821-R830
Explanation
The bug is that the user inputted token allowance is not the token allowance that ends up being submitted on chain. More precisely, if we show the user the token allowance screen and they customize it, the new
txParams.datais not used.The cause is the above linked codechange whereby an additional parameter was accidentally added to the result function of the selector creator, thereby rendering
customTxParamsDataundefined. With that parameter removed,customTxParamsDatawill now be defined as it was before, and will reflect the modified data in the case of a user editing a token allowance amount.