Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/16620/button href prop #16633

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix/16620/button href prop #16633

merged 2 commits into from
Nov 22, 2022

Conversation

garrettbear
Copy link
Contributor

Explanation

Fixes #16620
href prop was being used to change the root element but wasn't continued to be passed down.

Screenshots/Screencaps

Before

https://www.loom.com/share/fce9e713cfb5456aa80e6a286e145f8b

After

https://www.loom.com/share/44957e38da4c42b3a9975fac4342c8ef

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [bc5683e]
Page Load Metrics (2428 ± 187 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint9490417117082
domContentLoaded204736892421393189
load204736892428389187
domInteractive204736892421393188
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

highlights:

storybook

@garrettbear garrettbear merged commit e9508b4 into develop Nov 22, 2022
@garrettbear garrettbear deleted the fix/16620/button-href-prop branch November 22, 2022 20:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ButtonLink doesn't add href attribute to link html
4 participants