Updating network colors with design tokens #16543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| --inherit: inherit; | ||
| --transparent: transparent; | ||
|
|
||
| // DO NOT CHANGE | ||
| // Required for the QR reader to work properly | ||
| --qr-code-white-background: #fff; |
There was a problem hiding this comment.
Not used anywhere else in the code base. A search after removing resolves in no results
| @@ -46,7 +46,7 @@ | |||
| } | |||
|
|
|||
| button { | |||
| background-color: var(--flask-purple) !important; | |||
| background-color: var(--color-flask-default) !important; | |||
| border: 0 !important; | |||
| color: var(--color-primary-inverse); //@TODO: We don't have a generic inverse color, using this one for now | |||
| width: 200px; | |||
There was a problem hiding this comment.
NO VISUAL CHANGES - Gosh it feels good to tick off a long lasting "to do" 😁
Before
After
georgewrmarshall
added
area-UI
garrettbear
approved these changes
Nov 17, 2022
darkwing
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
During dark mode we ERADICATED almost every static hex value in the extension in favour of CSS color design tokens. This enabled color consistency across the extension and theming. The few static hex values that were left included network colors.
This PR updates those static hex values with the equivalent design tokens.
Screenshots/Screencaps
There should be no visual change so we are checking that both colors remain the same!
Before
network.color.light.before.mov
network.color.dark.before.mov
After
network.color.dark.after.mov
network.color.light.after.mov
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.