Skip the first token allowance screen if dapp proposing spending cap is 0

[adnansahovic]

Explanation

When a dapp proposed value for the spending cap is zero, the user is sent directly to the second screen in the flow and the spending cap is kept as 0 and the title copy reads Revoke the spending cap for your.

• Fixes Skip the first token allowance screen if a dapp is proposing a spending cap of 0 #16428

Screenshots/Screencaps

Before

Screen.Recording.2022-11-15.at.12.13.16.mov

After

Screen.Recording.2022-11-15.at.12.09.20.mov

Manual Testing Steps

1. Go to https://etherscan.io/token/0x6b175474e89094c44da98b954eedeac495271d0f#writeContract
2. Connect your wallet
3. Under approve input any address and 0 as the value
4. Click on write

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [c47a3f1]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2094 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	222	116	26	13
		domContentLoaded	1729	2454	2077	220	106
		load	1729	2486	2094	223	107
		domInteractive	1729	2454	2077	220	106

Bundle size diffs

• background: 0 bytes
• ui: 58 bytes
• common: 0 bytes

highlights:

storybook

• ui/pages/confirm-approve/confirm-approve.stories.js
• ui/pages/token-allowance/token-allowance.stories.js

[mirjanaKukic]

Verified by QA

[Prasert111]

https://polygonscan.com/address/0x1111111254fb6c44bac0bed2854e76f90643097d#code#L1

[bschorchit]

Could this PR be cherry picked in 10.23, @seaona @danjm ? It improves the UX for transactions requests that are revoking allowances (setting them to 0). It's not a blocker for the feature release though so it's ok if we prefer to leave this for 10.24.

[seaona]

oh sorry I missed the comment @bschorchit ! I will cherry pick the PR now. Thank you!!