Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating welcome message #16489

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Updating welcome message #16489

merged 5 commits into from
Nov 16, 2022

Conversation

darkwing
Copy link
Contributor

Updates welcome messaging for BETA, as well as reformats the current welcome message to use Typography.

BTWelcome

@darkwing darkwing requested a review from a team as a code owner November 14, 2022 19:26
@darkwing darkwing requested a review from Gtonizuka November 14, 2022 19:26
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the PR - P1 identifies PRs deemed priority for Extension team label Nov 14, 2022
@darkwing darkwing requested a review from SayaGT November 14, 2022 19:42
@metamaskbot
Copy link
Collaborator

Builds ready [595aa38]
Page Load Metrics (2189 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912253224467224
domContentLoaded170228272156265127
load173028272189258124
domInteractive170228272156265127
Bundle size diffs
  • background: 0 bytes
  • ui: 1329 bytes
  • common: 0 bytes

highlights:

storybook

SayaGT
SayaGT previously requested changes Nov 15, 2022
Copy link

@SayaGT SayaGT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @darkwing can we make "standard Terms" clickable instead of just "Terms"? Otherwise looks good to me!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can approve after the requested adjustment is made

@darkwing
Copy link
Contributor Author

@SayaGT @Gudahtt Updated to include 'standard' as part of the link!

@darkwing
Copy link
Contributor Author

Std

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [04fc2db]
Page Load Metrics (2109 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92131111115
domContentLoaded174525772080213102
load174525772109222107
domInteractive174525772080213102
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -861 bytes
  • ui: 4575 bytes
  • common: -12 bytes

highlights:

storybook

@darkwing darkwing dismissed SayaGT’s stale review November 16, 2022 20:16

Has 2 approvals, and was just a word change.

@darkwing darkwing merged commit d10e6a4 into develop Nov 16, 2022
@darkwing darkwing deleted the beta-welcome-messaging branch November 16, 2022 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants