Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "What's New" Notification for Improved token allowance experience #16465

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Added "What's New" Notification for Improved token allowance experience #16465

merged 3 commits into from
Nov 15, 2022

Conversation

adnansahovic
Copy link
Contributor

Explanation

Added "What's New" Notification for Improved token allowance experience

Screenshots/Screencaps

Screenshot 2022-11-11 at 10 37 40

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adnansahovic adnansahovic force-pushed the whats-new-token-allowance branch from 546cb46 to da13941 Compare November 11, 2022 15:46
@adnansahovic adnansahovic marked this pull request as ready for review November 11, 2022 15:51
@adnansahovic adnansahovic requested a review from a team as a code owner November 11, 2022 15:51
@adnansahovic adnansahovic force-pushed the whats-new-token-allowance branch from da13941 to 5aaf804 Compare November 14, 2022 12:26
@metamaskbot
Copy link
Collaborator

Builds ready [3899bad]
Page Load Metrics (2342 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint961721282010
domContentLoaded16202569232419292
load16882569234218689
domInteractive16202569232419292
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 79 bytes
  • common: 234 bytes

highlights:

storybook

@mirjanaKukic
Copy link
Contributor

Verified by QA

segun
segun approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brad-decker brad-decker merged commit f9ed4a5 into develop Nov 15, 2022
@brad-decker brad-decker deleted the whats-new-token-allowance branch November 15, 2022 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
@seaona seaona modified the milestones: v10.22.0, v10.23.0 Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@segun segun segun approved these changes

Assignees
No one assigned
Labels
rc-cherry-picked
Projects
None yet
Milestone
v10.23.0
Development

Successfully merging this pull request may close these issues.

Update the What's New
7 participants
@adnansahovic @metamaskbot @mirjanaKukic @segun @darkwing @brad-decker @seaona