-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade gulp-autoprefixer #16439
Merged
Merged
upgrade gulp-autoprefixer #16439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
previously approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change — makes sense to me!
Builds ready [bc63617]
Page Load Metrics (2314 ± 151 ms)
Bundle size diffs [🚀 Bundle size reduced!]
highlights: |
mcmire
approved these changes
Nov 10, 2022
darkwing
approved these changes
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
On every new process we are getting spammed with a message about caniuse browserlists being outdated. This PR upgrades the dependency that depends on that package, and removes the resolution for caniuse-browserslist which was pinned to an older version. In addition the autoprefixer output now caught two issues with us using 'end' and 'start' intsead of 'flex-end' and 'flex-start'. I also added a .browserslistrc file with our target browsers in it which autoprefixer will pickup on and use.
Screenshots/Screencaps
Before
After
Example of *helpful errors*
After cleanup
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist