Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gulp-autoprefixer #16439

Merged
merged 5 commits into from
Nov 15, 2022
Merged

upgrade gulp-autoprefixer #16439

merged 5 commits into from
Nov 15, 2022

Conversation

brad-decker
Copy link
Contributor

Explanation

On every new process we are getting spammed with a message about caniuse browserlists being outdated. This PR upgrades the dependency that depends on that package, and removes the resolution for caniuse-browserslist which was pinned to an older version. In addition the autoprefixer output now caught two issues with us using 'end' and 'start' intsead of 'flex-end' and 'flex-start'. I also added a .browserslistrc file with our target browsers in it which autoprefixer will pickup on and use.

Screenshots/Screencaps

Before

Screenshot from 2022-11-09 16-51-54

After

Example of *helpful errors*

Screenshot from 2022-11-09 16-56-14

After cleanup

Screenshot from 2022-11-09 17-01-38

Manual Testing Steps

  1. pull this branch
  2. yarn setup
  3. yarn start, notice no spamming of the caniuse-lite is outdated message
  4. profit

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • [x/ How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@brad-decker brad-decker added the needs-qa Label will automate into QA workspace label Nov 9, 2022
@brad-decker brad-decker requested a review from a team as a code owner November 9, 2022 23:05
@brad-decker brad-decker requested a review from mcmire November 9, 2022 23:05
mcmire
mcmire previously approved these changes Nov 10, 2022
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change — makes sense to me!

@metamaskbot
Copy link
Collaborator

Builds ready [bc63617]
Page Load Metrics (2314 ± 151 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911971142512
domContentLoaded179129332281302145
load185430322314315151
domInteractive179129332281302145
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 bytes
  • ui: 3275 bytes
  • common: -41 bytes

highlights:

storybook

@brad-decker brad-decker merged commit c9527e7 into develop Nov 15, 2022
@brad-decker brad-decker deleted the upgrade-gulp-autoprefixer branch November 15, 2022 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Label will automate into QA workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants