Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASK] Catch and display error in snaps insight #16416

Merged
merged 7 commits into from
Nov 9, 2022
Merged

[FLASK] Catch and display error in snaps insight #16416

merged 7 commits into from
Nov 9, 2022

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Nov 8, 2022 •
edited
Loading

Explanation

Allow snaps insight to catch errors thrown by the snap and display them in an error state. It also allows the empty state to display if the data is null

Screenshots/Screencaps

image

Manual Testing Steps

  • create a snap exporting onTransaction and make that function throw an error.
  • Initiate a transaction and look at the snap insight tab

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 8, 2022 10:47
@GuillaumeRx GuillaumeRx requested a review from segun November 8, 2022 10:47
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GuillaumeRx GuillaumeRx requested review from FrederikBolding and hmalik88 and removed request for segun November 8, 2022 10:47
@GuillaumeRx GuillaumeRx self-assigned this Nov 8, 2022
@GuillaumeRx GuillaumeRx mentioned this pull request Nov 8, 2022
Merged
@metamaskbot
Copy link
Collaborator

Builds ready [3d55299]
Page Load Metrics (2224 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint952099215432208
domContentLoaded172527722203241116
load172527722224245118
domInteractive172527722203241116

highlights:

storybook

@FrederikBolding FrederikBolding mentioned this pull request Nov 8, 2022
Closed
@metamaskbot
Copy link
Collaborator

Builds ready [eb5d2d0]
Page Load Metrics (2086 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90148101136
domContentLoaded158925192058257123
load158925432086262126
domInteractive158925192058257123

highlights:

storybook

@FrederikBolding FrederikBolding merged commit d154cc7 into develop Nov 9, 2022
@FrederikBolding FrederikBolding deleted the gr/snaps-insight-error-state branch November 9, 2022 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmalik88 hmalik88 hmalik88 approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees

@GuillaumeRx GuillaumeRx

Labels
flask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add empty/error state for transaction insights
4 participants
@GuillaumeRx @metamaskbot @FrederikBolding @hmalik88