Fix orphaned data warning #16413
Merged
Fix orphaned data warning #16413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Signed-off-by: Akintayo A. Olusegun <[email protected]>
Signed-off-by: Akintayo A. Olusegun <[email protected]>
segun
force-pushed
the
fix-orphaned-data-warning
branch
from
b545aba to
5ed0dab
Compare
Builds ready [5ed0dab]
Page Load Metrics (2158 ± 89 ms)
|
jpuri
approved these changes
Nov 8, 2022
NiranjanaBinoy
approved these changes
Nov 8, 2022
digiwand
reviewed
Nov 9, 2022
| @@ -9,6 +9,14 @@ import pump from 'pump'; | |||
| */ | |||
| export function setupMultiplex(connectionStream) { | |||
| const mux = new ObjectMultiplex(); | |||
| /** | |||
| * We are using this streams to send keep alive message between backend/ui without setting up a multiplexer | |||
There was a problem hiding this comment.
maybe
Suggested change
| * We are using this streams to send keep alive message between backend/ui without setting up a multiplexer | |
| * We are using these streams to send state and keep-alive messages between the backend and ui without setting up multiplex connections. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We have some messages we send back/forth between UI and background without using the multiplexer, this generates lots of warnings in the console.
ObjectMultiplex - orphaned data for stream "${message}".This PR fixes this by asking the multiplexer to ignore these messages.
Screenshots/Screencaps
Manual Testing Steps
yarn start:mv3Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.