Continue converting tests from enzyme to @testing-library/react #16401

tmashuang · 2022-11-07T19:58:37Z

Tests converted:

button-group-component.test.js
page-container-footer.component.test.js
site-origin.test.js
advanced-tab.component.test.js
view-quote-price-difference.test.js

Adds relevant snapshots and test ids to associated files.

github-actions · 2022-11-07T19:58:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2022-11-07T22:25:04Z

Builds ready [0ecce6c]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2042 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	169	101	17	8
		domContentLoaded	1765	2241	2028	145	70
		load	1786	2263	2042	138	66
		domInteractive	1765	2241	2028	145	70

highlights:

storybook

metamaskbot · 2022-11-08T15:04:06Z

Builds ready [9792460]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2189 ± 117 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	143	117	14	7
		domContentLoaded	1663	2606	2166	242	116
		load	1663	2606	2189	244	117
		domInteractive	1663	2606	2166	242	116

highlights:

storybook

metamaskbot · 2022-11-08T16:48:11Z

Builds ready [1cece26]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2227 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	2266	213	471	226
		domContentLoaded	1985	2366	2202	91	44
		load	1985	2437	2227	106	51
		domInteractive	1985	2366	2202	91	44

highlights:

storybook

metamaskbot · 2022-11-08T18:05:06Z

Builds ready [7b1465b]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2025 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	241	105	32	16
		domContentLoaded	1646	2420	2007	212	102
		load	1646	2420	2025	204	98
		domInteractive	1646	2420	2007	212	102

highlights:

storybook

metamaskbot · 2022-11-08T22:43:08Z

Builds ready [0b54838]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2225 ± 126 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	2418	232	502	241
		domContentLoaded	1728	2677	2195	254	122
		load	1728	2678	2225	261	126
		domInteractive	1728	2677	2195	254	122

highlights:

storybook

metamaskbot · 2022-11-09T11:57:28Z

Builds ready [d2ec51c]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2358 ± 180 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	3001	261	629	302
		domContentLoaded	1726	3002	2334	375	180
		load	1726	3002	2358	375	180
		domInteractive	1726	3001	2334	375	180

highlights:

storybook

metamaskbot · 2022-11-09T13:15:24Z

Builds ready [e474534]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2143 ± 139 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	123	100	8	4
		domContentLoaded	1669	2619	2108	288	138
		load	1725	2704	2143	289	139
		domInteractive	1669	2619	2108	288	138

highlights:

storybook

tmashuang added 7 commits November 7, 2022 11:45

Add transaction activity log component

0167795

Remove duplicate tx activity log snapshot.

477770c

Convert View Quote Difference test to tlr.

19a62d3

Convert Site Origin test to tlr.

65cfe69

Convert Button Group to test to tlr.

41c1c2f

Convert Page Container Footer to tlr.

61d68d0

Convert Advanced Tab to tlr.

5c6839b

tmashuang requested a review from a team as a code owner November 7, 2022 19:58

tmashuang requested a review from georgewrmarshall November 7, 2022 19:58

tmashuang added 2 commits November 7, 2022 12:55

Lint fix

1e9fde7

Lint fix 2

0ecce6c

brad-decker approved these changes Nov 7, 2022

View reviewed changes

Merge branch 'develop' into rm-enzyme

9792460

Merge branch 'develop' into rm-enzyme

1cece26

Merge branch 'develop' into rm-enzyme

7b1465b

tmashuang added 2 commits November 8, 2022 10:14

Merge branch 'develop' into rm-enzyme

f8cb883

Merge branch 'develop' into rm-enzyme

0b54838

Merge branch 'develop' into rm-enzyme

d2ec51c

Merge branch 'develop' into rm-enzyme

e474534

darkwing approved these changes Nov 9, 2022

View reviewed changes

brad-decker merged commit 25bb6ef into develop Nov 9, 2022

brad-decker deleted the rm-enzyme branch November 9, 2022 17:20

github-actions bot locked and limited conversation to collaborators Nov 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Continue converting tests from enzyme to @testing-library/react #16401

Continue converting tests from enzyme to @testing-library/react #16401

tmashuang commented Nov 7, 2022

github-actions bot commented Nov 7, 2022

metamaskbot commented Nov 7, 2022

metamaskbot commented Nov 8, 2022

metamaskbot commented Nov 8, 2022

metamaskbot commented Nov 8, 2022

metamaskbot commented Nov 8, 2022

metamaskbot commented Nov 9, 2022

metamaskbot commented Nov 9, 2022

Continue converting tests from enzyme to @testing-library/react #16401

Continue converting tests from enzyme to @testing-library/react #16401

Conversation

tmashuang commented Nov 7, 2022

github-actions bot commented Nov 7, 2022

metamaskbot commented Nov 7, 2022

highlights:

metamaskbot commented Nov 8, 2022

highlights:

metamaskbot commented Nov 8, 2022

highlights:

metamaskbot commented Nov 8, 2022

highlights:

metamaskbot commented Nov 8, 2022

highlights:

metamaskbot commented Nov 9, 2022

highlights:

metamaskbot commented Nov 9, 2022

highlights: