Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pull Request template #16367

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Update Pull Request template #16367

merged 1 commit into from
Nov 4, 2022

Conversation

PeterYinusa
Copy link
Contributor

Explanation

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b2fbbf2]
Page Load Metrics (2300 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101144116147
domContentLoaded167629002281283136
load167629002300292140
domInteractive167629002281283136

@PeterYinusa PeterYinusa marked this pull request as ready for review November 3, 2022 16:57
@PeterYinusa PeterYinusa requested a review from a team as a code owner November 3, 2022 16:57
@PeterYinusa PeterYinusa requested a review from mcmire November 3, 2022 16:57
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@PeterYinusa PeterYinusa changed the title Update PULL_REQUEST_TEMPLATE.md Update Pull Request template Nov 4, 2022
@PeterYinusa PeterYinusa merged commit 726b7b5 into develop Nov 4, 2022
@PeterYinusa PeterYinusa deleted the pr-template branch November 4, 2022 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants