Token allowance i18n interpolation system #16347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adnansahovic
changed the title
|
Verified by QA |
|
@adnansahovic can you rebase, then review can continue. LGTM thouigh |
adnansahovic
force-pushed
the
token-allowance-i18n-interpolation-system
branch
from
d5b65d3 to
b4c5b51
Compare
Hi @brad-decker, Done, also modified revokeSpendingCap (#16157 (review)) |
Builds ready [8168c85]
Page Load Metrics (2547 ± 219 ms)
highlights:storybook
|
brad-decker
previously approved these changes
Nov 10, 2022
adnansahovic
force-pushed
the
token-allowance-i18n-interpolation-system
branch
from
8168c85 to
14c3785
Compare
brad-decker
approved these changes
Nov 18, 2022
Builds ready [14c3785]
Page Load Metrics (2028 ± 77 ms)
Bundle size diffs
highlights:storybook
|
danjm
approved these changes
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixed setSpendingCap and revokeSpendingCap(#16157 (review)) locale string using the i18n interpolation system.
More Information
setSpendingCaplocale string to properly use our i18n interpolation system #16234Manual Testing Steps
BEFORE TESTING - in your .metamaskrc file, set TOKEN_ALLOWANCE_IMPROVEMENTS=1 and then start the app
To see how the screen looks like when the enhanced gas fee is enabled, go to Settings (Experimental tab) and enable it (Enable enhanced gas fee UI toggle)