BETA - Update verbiage for success messages after onboarding #16343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
force-pushed
the
beta-branding-terms
branch
2 times, most recently
from
e45e6a1
to
011e8bb
Compare
darkwing
force-pushed
the
beta-branding-terms
branch
from
011e8bb
to
f098900
Compare
Builds ready [f098900]
Page Load Metrics (2431 ± 214 ms)
highlights:storybook
|
digiwand
reviewed
Nov 4, 2022
| {t('betaTerms')} | ||
| <Chip | ||
| borderColor={COLORS.PRIMARY_DEFAULT} | ||
| backgroundColor={COLORS.PRIMARY_DEFAULT} |
There was a problem hiding this comment.
After adding these colors, this Chip looks very similar to our Button components, but it doesn't share the Button behaviors. I think I kind of see why it works here because it also sends the user to the link when clicked on.
curious if you have any thoughts here regarding this Chip instance @georgewrmarshall
There was a problem hiding this comment.
Yeah I agree was hesitant about the tag UI for this exact reason. I've asked for some design input from @Akatori-Design in the Figma file
There was a problem hiding this comment.
@georgewrmarshall
What if we just use the standard tag style?
There was a problem hiding this comment.
I'm fine with that! We have this component available for use! https://metamask.github.io/metamask-storybook/?path=/docs/ui-components-component-library-tag-tag-stories-js--default-story
Gudahtt
previously approved these changes
Nov 9, 2022
Builds ready [7df2f60]
Page Load Metrics (2166 ± 104 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
highlights:storybook
|
darkwing
force-pushed
the
beta-branding-terms
branch
from
7df2f60
to
f55dd80
Compare
Gudahtt
approved these changes
Nov 9, 2022
Builds ready [f55dd80]
Page Load Metrics (2278 ± 124 ms)
highlights:storybook
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Simply changes app name in onboarding if user is using BETA, as well as about/info page link:
More Information