Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Update e2e tests for new react test-snaps page #16324

Merged
merged 32 commits into from
Nov 16, 2022

Conversation

bowensanders
Copy link
Contributor

This is attempting to upgrade the e2e tests to work with the new react version of test-snaps

see MetaMask/test-snaps#81

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bowensanders
Copy link
Contributor Author

In order to test the first e2e, error-

  • checkout the bs/react branch on test-snaps
  • yarn install && yarn build && yarn start
    that will start the servers for the test page

to run the tests:

  • rm -r node_modules && yarn setup && yarn build:test:flask - this should work unless you get lavamoat errors later
  • SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/snaps/test-snap-error.spec.js --leave-running - this will leave the page running until you ^c out of it when the test fails

@bowensanders
Copy link
Contributor Author

bowensanders commented Nov 12, 2022

Tests are failing on the bip-32 snap test, as if the new key-tree changers aren't merged here.

@metamaskbot
Copy link
Collaborator

Builds ready [d7b69c0]
Page Load Metrics (2131 ± 132 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002499235520250
domContentLoaded169724942110272131
load169724942131275132
domInteractive169724942110272131
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2496822 bytes
  • ui: 37153 bytes
  • common: -18591 bytes

@bowensanders bowensanders marked this pull request as ready for review November 16, 2022 18:21
@bowensanders bowensanders requested a review from a team as a code owner November 16, 2022 18:21
@FrederikBolding FrederikBolding changed the title Update e2e tests for new react test-snaps page [FLASK] Update e2e tests for new react test-snaps page Nov 16, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [9bec385]
Page Load Metrics (2123 ± 134 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92156111157
domContentLoaded167225372095272131
load167225402123278134
domInteractive167225372095272131
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -2496822 bytes
  • ui: 37153 bytes
  • common: -18591 bytes

@bowensanders bowensanders merged commit 327272f into develop Nov 16, 2022
@bowensanders bowensanders deleted the bowen/react-e2e-tests branch November 16, 2022 21:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
@bowensanders
Copy link
Contributor Author

closes #16532

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants