Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BETA - Update logo imagery #16304

Merged
merged 6 commits into from
Nov 9, 2022
Merged

BETA - Update logo imagery #16304

merged 6 commits into from
Nov 9, 2022

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Oct 28, 2022 •
edited
Loading

Explanation

Updates all BETA imagery to new logos.

More Information

@darkwing darkwing requested a review from a team as a code owner October 28, 2022 17:27
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall previously approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @darkwing, hope you don't mind I've updated the colors and added a story so it's possible to view all the different types of logos. Short of updating the component to accept a type prop it's still a manual process. But have checked all colors are correct

Screen Shot 2022-10-31 at 5 27 26 PM

Screen Shot 2022-10-31 at 5 27 48 PM

Screen Shot 2022-10-31 at 5 28 02 PM

@hilvmason hilvmason added the PR - P1 identifies PRs deemed priority for Extension team label Nov 3, 2022
@darkwing darkwing requested a review from SayaGT November 3, 2022 22:35
brad-decker
brad-decker previously approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

georgewrmarshall
georgewrmarshall previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metamaskbot
Copy link
Collaborator

Builds ready [8eaada7]
Page Load Metrics (2077 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint862761114120
domContentLoaded16112307207419091
load16112307207719292
domInteractive16112307207419091

highlights:

storybook

@darkwing darkwing merged commit f05acf8 into develop Nov 9, 2022
@darkwing darkwing deleted the beta-images branch November 9, 2022 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@brad-decker brad-decker brad-decker approved these changes

@Gtonizuka Gtonizuka Awaiting requested review from Gtonizuka Gtonizuka is a code owner automatically assigned from MetaMask/extension-devs

@SayaGT SayaGT Awaiting requested review from SayaGT

Assignees
No one assigned
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darkwing @metamaskbot @brad-decker @georgewrmarshall @hilvmason