modified transaction complete popup #16300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adnansahovic
force-pushed
the
transaction-complete-popup
branch
from
127df80 to
827410d
Compare
Builds ready [827410d]
Page Load Metrics (2169 ± 88 ms)
|
|
Verified by QA |
adnansahovic
force-pushed
the
transaction-complete-popup
branch
from
12de561 to
478b8ef
Compare
Builds ready [478b8ef]
Page Load Metrics (2083 ± 81 ms)
|
adnansahovic
force-pushed
the
transaction-complete-popup
branch
from
478b8ef to
b23803b
Compare
Builds ready [b23803b]
Page Load Metrics (1993 ± 107 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brad-decker
previously approved these changes
Nov 21, 2022
|
@adnansahovic needs a rebase. |
adnansahovic
force-pushed
the
transaction-complete-popup
branch
from
b23803b to
0a6fcec
Compare
deleted upperCase function deleted replaceAll fixed lint
adnansahovic
force-pushed
the
transaction-complete-popup
branch
from
0a6fcec to
e5d14a2
Compare
Builds ready [e5d14a2]
Page Load Metrics (2572 ± 259 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Hi @brad-decker, Done. |
jpuri
reviewed
Nov 30, 2022
app/scripts/platforms/extension.js
Outdated
| @@ -160,10 +162,11 @@ export default class ExtensionPlatform { | |||
|
|
|||
| const url = getBlockExplorerLink(txMeta, rpcPrefs); | |||
| const nonce = parseInt(txMeta.txParams.nonce, 16); | |||
| const view = getURLHostName(url).replace(/([.]\w+)$/u, ''); | |||
There was a problem hiding this comment.
- Is this way of deriving view name from URL good enough ?
startCase(toLower(view))this conversion can also be probably done here.
Builds ready [cc5f3b8]
Page Load Metrics (2355 ± 152 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brad-decker
suggested changes
Dec 1, 2022
| @@ -160,10 +162,13 @@ export default class ExtensionPlatform { | |||
|
|
|||
| const url = getBlockExplorerLink(txMeta, rpcPrefs); | |||
| const nonce = parseInt(txMeta.txParams.nonce, 16); | |||
| const view = startCase( | |||
| toLower(getURLHostName(url).replace(/([.]\w+)$/u, '')), | |||
There was a problem hiding this comment.
I have to agree with @jpuri on this one. Your screenshot for Mumbai PolygonScan makes it appear that this works with subdomains (mumbai) but then Ehterscan would have a 'www' proceeding it? And if I do a naive assertion on this regex statement in console:
const y = new URL('https://mumbai.polygonscan.com/');
> undefined
y.hostname.replace(/([.]\w+)$/u, '')
> 'mumbai.polygonscan'
y.hostname.replace(/([.]\w+)$/ug, '')
> 'mumbai.polygonscan'
There was a problem hiding this comment.
Hi @jpuri and @brad-decker,
I tried this solution again, I changed Mumbai block explorer link to Etherscan link and I saw this notification "View on Etherscan" (this is just for testing). Can you please review this again?
You can see the following video:
Screen.Recording.2022-12-02.at.11.32.07.mov
There was a problem hiding this comment.
I missed the call to 'startCase' which is the reason the magic works. Alright i'm good with this. Thanks for pushing back @adnansahovic
brad-decker
approved these changes
Dec 13, 2022
Builds ready [3b788b0]
Page Load Metrics (1297 ± 91 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
approved these changes
Jan 4, 2023
|
Merging as there are two approvals! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Changed the text on popup after the completion of transaction
More Information
Screenshots/Screencaps
Before
After
Manual Testing Steps