Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Restore tests #16298

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[E2E] Restore tests #16298

merged 2 commits into from
Oct 31, 2022

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Oct 28, 2022

Explanation

Add tests for Restore functionality.

The test uploads a settings file MetaMaskUserData.json that contains an address book entry, then checks the entry is present to ensure the data was restored successfully

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

yarn test:e2e:single test/e2e/tests/backup-restore.spec.js --browser firefox
yarn test:e2e:single test/e2e/tests/backup-restore.spec.js --browser chrome

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@PeterYinusa PeterYinusa added the needs-qa Label will automate into QA workspace label Oct 28, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa marked this pull request as ready for review October 28, 2022 09:57
@PeterYinusa PeterYinusa requested a review from a team as a code owner October 28, 2022 09:57
@PeterYinusa PeterYinusa requested a review from hmalik88 October 28, 2022 09:57
@metamaskbot
Copy link
Collaborator

Builds ready [7effa4f]
Page Load Metrics (2236 ± 150 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint942299266497239
domContentLoaded185330852214313150
load185331492236312150
domInteractive185330852214313150

@PeterYinusa PeterYinusa merged commit 88a6f37 into develop Oct 31, 2022
@PeterYinusa PeterYinusa deleted the backup-and-restore branch October 31, 2022 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Label will automate into QA workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants