-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HelpText component #16293
Merged
Merged
Adding HelpText component #16293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
area-UI
Relating to the user interface.
team-design-system
All issues relating to design system in Extension
IA/NAV
labels
Oct 27, 2022
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
changed the title
Adding initial HelpText component (WIP)
Adding HelpText component (WIP)
Oct 27, 2022
georgewrmarshall
requested review from
garrettbear,
NidhiKJha and
Akatori-Design
October 27, 2022 14:32
georgewrmarshall
changed the title
Adding HelpText component (WIP)
Adding HelpText component
Oct 27, 2022
Builds ready [6956541]
Page Load Metrics (2384 ± 131 ms)
highlights: |
brad-decker
approved these changes
Nov 3, 2022
NidhiKJha
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-UI
Relating to the user interface.
team-design-system
All issues relating to design system in Extension
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adding
HelpText
component that will eventually be used withTextField
andLabel
to createFormTextField
.More Information
Screenshots/Screencaps
After
Screen.Recording.2022-10-27.at.2.34.52.PM.mov
Manual Testing Steps
HelpText
in the search barPre-Merge Checklist
+ If there are functional changes:
Acceptance Criteria
className
prop and the PropType descriptions are all the samesize
and are suggesting the use of the generalizeddesign-system.js
constants e.g.SIZES
as the primary option but noting the component consts in the documentation and using them for propType validation and storybook controls onlyimgSrc
,imgAlt
(html element + attribute) (needs audit)size
prop would beexport const Size = (args) => (
size
prop would be### Size
mm-
prefix to all classNames// TODO:
comment so we can search for them at a later date e.g. blocking components etc