Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASK] Fix flaky BIP-32 E2E test #16255

Merged
merged 1 commit into from
Oct 24, 2022
Merged

[FLASK] Fix flaky BIP-32 E2E test #16255

merged 1 commit into from
Oct 24, 2022

Conversation

FrederikBolding
Copy link
Member

Explanation

Improves the stability of the BIP32 snaps E2E test.

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 22, 2022 16:18
@metamaskbot
Copy link
Collaborator

Builds ready [6413607]
Page Load Metrics (2234 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852238203467224
domContentLoaded2030233022198340
load2050240722348842
domInteractive2029233022198340

@FrederikBolding FrederikBolding merged commit 359f782 into develop Oct 24, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-flaky-bip32-e2e branch October 24, 2022 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

@adonesky1 adonesky1 Awaiting requested review from adonesky1 adonesky1 was automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrederikBolding @metamaskbot @Mrtenz @rekmarks