Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue converting tests from enzyme to @testing-library/react #16175

Merged
merged 10 commits into from
Oct 20, 2022

Conversation

tmashuang
Copy link
Contributor

Tests converted:

transaction-breakdown-row.component.test.js
transaction-status.component.test.js
user-preferenced-currency-display.test.js (consolidated)
user-preferenced-currency-input.test.js (consolidated)
user-preferenced-token-input.test.js (consolidated)

Adds relevant snapshots and test ids to associated files.

@tmashuang tmashuang requested a review from a team as a code owner October 12, 2022 20:17
@tmashuang tmashuang requested a review from ryanml October 12, 2022 20:17
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [dabf6fe]
Page Load Metrics (2343 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922244218465223
domContentLoaded21142694232517182
load21702747234318086
domInteractive21142694232517182

@metamaskbot
Copy link
Collaborator

Builds ready [252cd19]
Page Load Metrics (2567 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982734252570274
domContentLoaded213730142544231111
load213730142567245117
domInteractive213730142544231111

@metamaskbot
Copy link
Collaborator

Builds ready [e01e1a0]
Page Load Metrics (2404 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932111253115
domContentLoaded21322640238915072
load21542640240414368
domInteractive21322640238915072

@metamaskbot
Copy link
Collaborator

Builds ready [eb5457c]
Page Load Metrics (2348 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87145112178
domContentLoaded21302774232814469
load21512774234814771
domInteractive21302774232814469

@tmashuang tmashuang merged commit 8075a39 into develop Oct 20, 2022
@tmashuang tmashuang deleted the rm-enzyme branch October 20, 2022 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants