Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent storybook build failure #16124

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 7, 2022

The CI job for building storybook will fail occasionally, presumably due to a Node.js process running out of heap memory. This job is the only build job that runs with default Node.js memory settings.

It has been updated to use a larger instance size and to set the heap size to 2GB, matching our other build jobs.

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

The CI job for building storybook will fail occasionally, presumably
due to a Node.js process running out of heap memory. This job is the
only build job that runs with default Node.js memory settings.

It has been updated to use a larger instance size and to set the heap
size to 2GB, matching our other build jobs.
@Gudahtt Gudahtt marked this pull request as ready for review October 7, 2022 13:46
@Gudahtt Gudahtt requested review from a team and kumavis as code owners October 7, 2022 13:46
@Gudahtt Gudahtt requested a review from hmalik88 October 7, 2022 13:46
@metamaskbot
Copy link
Collaborator

Builds ready [08dc430]
Page Load Metrics (2488 ± 159 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982206222455219
domContentLoaded177133362475323155
load177133632488332159
domInteractive177133362475323155

@Gudahtt Gudahtt merged commit e4dc8ce into develop Oct 7, 2022
@Gudahtt Gudahtt deleted the fix-intermittent-storybook-build-failure branch October 7, 2022 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
@georgewrmarshall
Copy link
Contributor

Thank you @Gudahtt 🙏 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants