Fixes optional chaining bug in storybook #16103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, if a UI component uses optional chaining
?.
in it's component code or stoybook files it will break the args table that shows all of the proptypes that can be rendered from the README.mdx fileThis is a problem because you can't read the props table :)
This adds a resolution for ast-types to
package.json
file. We can remove this resolution once we upgrade to Webpack 5More Information
React-docgen fails to parse components with optional chaining. reactjs/react-docgen#463 (comment)
Screenshots/Screencaps
Before
After
Manual Testing Steps
UpdateNicknamePopover
in the search bar (it uses optional chaining in it's component code)Pre-Merge Checklist
+ If there are functional changes: