Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes optional chaining bug in storybook #16103

Merged

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Oct 6, 2022

Explanation

Currently, if a UI component uses optional chaining ?. in it's component code or stoybook files it will break the args table that shows all of the proptypes that can be rendered from the README.mdx file

This is a problem because you can't read the props table :)

This adds a resolution for ast-types to package.json file. We can remove this resolution once we upgrade to Webpack 5

More Information

Screenshots/Screencaps

Before

Screen Shot 2022-10-05 at 8 29 16 PM

After

Screen Shot 2022-10-05 at 8 28 50 PM

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review October 6, 2022 03:35
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner October 6, 2022 03:35
@metamaskbot
Copy link
Collaborator

Builds ready [b9da9d6]
Page Load Metrics (2068 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8212597126
domContentLoaded17762249205112560
load17962357206813464
domInteractive17762249205112560

@georgewrmarshall georgewrmarshall merged commit db59186 into develop Oct 6, 2022
@georgewrmarshall georgewrmarshall deleted the fix/12994/storybook-optional-chaining-args-table branch October 6, 2022 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook ArgsTable doesn't work with components that use optional chaning(?.)
4 participants