Feat/15951/add button secondary #16097

garrettbear · 2022-10-05T19:07:10Z

Explanation

Adding ButtonSecondary built off of ButtonBase.

(similar to ButtonPrimary)

Sizes: SM, MD, & LG
Types: Normal (default) and Danger (enabled with danger prop = true)

Figma

More Information

Fixes [Ext Nav] Create component: ButtonSecondary #15092

Screenshots/Screencaps

Manual Testing Steps

yarn test:unit:jest .ui/components/component-library/button-secondary/button-secondary.test.js

Pre-Merge Checklist

PR template is filled out
IF this PR fixes a bug, a test that would have caught the bug has been added
PR is linked to the appropriate GitHub issue
PR has been added to the appropriate release Milestone

+ If there are functional changes:

Manual testing complete & passed
"Extension QA Board" label has been applied

github-actions · 2022-10-05T19:07:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall

Some tiny suggestions otherwise 🔥🔥🔥

ui/components/component-library/button-secondary/README.mdx

ui/components/component-library/button-secondary/button-secondary.js

metamaskbot · 2022-10-05T21:19:51Z

Builds ready [77424c7]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2440 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	2370	229	492	236
		domContentLoaded	2051	2882	2424	222	107
		load	2051	2905	2440	220	105
		domInteractive	2051	2882	2424	222	107

highlights:

storybook

Co-authored-by: George Marshall <[email protected]>

NidhiKJha

LGTM! 🔥🔥

NidhiKJha · 2022-10-06T17:35:29Z

ui/components/component-library/button-secondary/button-secondary.stories.js

+  <>
+    <ButtonSecondary {...args} />
+  </>


Nit: Do we need a fragment here?

nope. can be removed.

metamaskbot · 2022-10-06T17:57:50Z

Builds ready [f123e52]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2404 ± 136 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	208	113	26	12
		domContentLoaded	1981	3052	2387	277	133
		load	1981	3078	2404	283	136
		domInteractive	1981	3052	2387	277	133

highlights:

storybook

georgewrmarshall

LGTM 🔥

metamaskbot · 2022-10-06T22:39:24Z

Builds ready [1804d0c]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2217 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	2352	215	490	235
		domContentLoaded	1896	2452	2198	136	66
		load	1896	2452	2217	133	64
		domInteractive	1896	2452	2198	136	66

highlights:

storybook

garrettbear added 2 commits October 5, 2022 11:56

add button secondary

ed31160

revert change to shadow stories

88e113a

garrettbear added team-design-system All issues relating to design system in Extension IA/NAV labels Oct 5, 2022

garrettbear requested review from georgewrmarshall and NidhiKJha October 5, 2022 19:07

garrettbear self-assigned this Oct 5, 2022

garrettbear requested a review from a team as a code owner October 5, 2022 19:07

georgewrmarshall reviewed Oct 5, 2022

View reviewed changes

test and docs update

77424c7

garrettbear and others added 2 commits October 6, 2022 09:13

Update ui/components/component-library/button-secondary/README.mdx

24108b8

Co-authored-by: George Marshall <[email protected]>

Merge branch 'develop' into feat/15951/add-button-secondary

f123e52

garrettbear requested a review from georgewrmarshall October 6, 2022 16:34

NidhiKJha requested changes Oct 6, 2022

View reviewed changes

georgewrmarshall previously approved these changes Oct 6, 2022

View reviewed changes

remove unused fragment

1804d0c

garrettbear dismissed georgewrmarshall’s stale review via 1804d0c October 6, 2022 21:35

garrettbear requested review from NidhiKJha and georgewrmarshall October 6, 2022 21:35

georgewrmarshall approved these changes Oct 6, 2022

View reviewed changes

NidhiKJha approved these changes Oct 7, 2022

View reviewed changes

garrettbear merged commit 958cfe6 into develop Oct 7, 2022

garrettbear deleted the feat/15951/add-button-secondary branch October 7, 2022 15:50

github-actions bot locked and limited conversation to collaborators Oct 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/15951/add button secondary #16097

Feat/15951/add button secondary #16097

garrettbear commented Oct 5, 2022 •

edited

Loading

github-actions bot commented Oct 5, 2022

georgewrmarshall left a comment

metamaskbot commented Oct 5, 2022

NidhiKJha left a comment

NidhiKJha Oct 6, 2022

garrettbear Oct 6, 2022

metamaskbot commented Oct 6, 2022

georgewrmarshall left a comment

metamaskbot commented Oct 6, 2022

Feat/15951/add button secondary #16097

Feat/15951/add button secondary #16097

Conversation

garrettbear commented Oct 5, 2022 • edited Loading

Explanation

More Information

Screenshots/Screencaps

Manual Testing Steps

Pre-Merge Checklist

+ If there are functional changes:

github-actions bot commented Oct 5, 2022

georgewrmarshall left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 5, 2022

highlights:

NidhiKJha left a comment

Choose a reason for hiding this comment

NidhiKJha Oct 6, 2022

Choose a reason for hiding this comment

garrettbear Oct 6, 2022

Choose a reason for hiding this comment

metamaskbot commented Oct 6, 2022

highlights:

georgewrmarshall left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 6, 2022

highlights:

garrettbear commented Oct 5, 2022 •

edited

Loading