Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that portfolio tooltip does not show if new custom network popup is shown #16090

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Oct 5, 2022

Fixes #16065

@danjm danjm requested a review from a team as a code owner October 5, 2022 13:45
@danjm danjm requested a review from georgewrmarshall October 5, 2022 13:45
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we have any other modals that might overlap like the added new network modals?

I guess this is the right behaviour as well because tooltips render outside of the root html element that loads the app

Screen Shot 2022-10-05 at 12 50 53 PM

@PeterYinusa PeterYinusa added this to the v10.21.0 milestone Oct 6, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [4b06221]
Page Load Metrics (2184 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861851072210
domContentLoaded18742357217311756
load18742357218412057
domInteractive18742357217311756

@seaona seaona merged commit 8b2e137 into develop Oct 14, 2022
@seaona seaona deleted the fix-portfolio-network-overlap branch October 14, 2022 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Overlapping Portfolio Site info box with Added Network info box
6 participants