Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower coverage requirement #16087

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 5, 2022

The function coverage requirement was raised too high in #16040, breaking CI on develop and in any new branches. This PR removes the decimal, lowering the coverage requirement slightly and fixing CI.

@FrederikBolding FrederikBolding requested a review from a team as a code owner October 5, 2022 11:14
@metamaskbot
Copy link
Collaborator

Builds ready [b571e54]
Page Load Metrics (2660 ± 160 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint943551405526
domContentLoaded200631012636326157
load200632732660333160
domInteractive200631012636326157

@FrederikBolding FrederikBolding merged commit 047d664 into develop Oct 5, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-coverage-requirement branch October 5, 2022 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants