Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASK] [email protected] #16069

Merged
merged 10 commits into from
Oct 7, 2022
Merged

[FLASK] [email protected] #16069

merged 10 commits into from
Oct 7, 2022
+113 −120

Conversation

FrederikBolding
Copy link
Member

Bumps Snaps packages to 0.22.0 and handles any breaking changes.

@metamaskbot
Copy link
Collaborator

Builds ready [49b9163]
Page Load Metrics (2539 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002458233511245
domContentLoaded200629972516225108
load200630212539238114
domInteractive200629972516225108

@FrederikBolding FrederikBolding marked this pull request as ready for review October 5, 2022 11:16
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 5, 2022 11:16
GuillaumeRx
GuillaumeRx previously approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm 👌

@metamaskbot
Copy link
Collaborator

Builds ready [7350a80]
Page Load Metrics (2446 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932530236526253
domContentLoaded21032634242914570
load21032664244615374
domInteractive21032634242914570

@metamaskbot
Copy link
Collaborator

Builds ready [23241c7]
Page Load Metrics (2308 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92137108136
domContentLoaded21042913227517383
load21042939230817785
domInteractive21042913227517383

highlights:

storybook

bowensanders
bowensanders approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@bowensanders bowensanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here LGTM
also this fixed the display problem

@bowensanders
Copy link
Contributor

Passes QA testing. G2G

@FrederikBolding FrederikBolding merged commit 7ba0f78 into develop Oct 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
@seaona seaona added this to the v10.21.0 milestone Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bowensanders bowensanders bowensanders approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

@PeterYinusa PeterYinusa Awaiting requested review from PeterYinusa PeterYinusa is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
rc-cherry-picked
Projects
None yet
Milestone
v10.21.0
Development

Successfully merging this pull request may close these issues.
6 participants
@FrederikBolding @metamaskbot @bowensanders @Mrtenz @GuillaumeRx @seaona