forwarding refs to Box and Text component #16062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
added
area-UI
georgewrmarshall
commented
Oct 3, 2022
| @@ -29,61 +29,72 @@ export const ValidTags = [ | |||
| 'strong', | |||
| 'ul', | |||
| 'label', | |||
| 'input', | |||
There was a problem hiding this comment.
We are using the Text component and polymorphic prop to create the input element in TextInputBase component PR https://github.com/MetaMask/metamask-extension/pull/16043/files#diff-d3b7305f6fb5c8d3d68007b90b8edefae588ed1141b5319e3785c4bc4f03c218R138-R167
georgewrmarshall
commented
Oct 3, 2022
| const mockRef = jest.fn(); | ||
| render(<Text ref={mockRef} />); | ||
| expect(mockRef).toHaveBeenCalledTimes(1); | ||
| }); |
There was a problem hiding this comment.
I don't think this is the most robust test but I struggled to find a reliable way to unit test forwarding refs open to suggestions
brad-decker
approved these changes
Oct 4, 2022
theweb3dev
approved these changes
Oct 4, 2022
digiwand
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the Box component does not forward refs down to it's root html element
This is a problem because we use the Box component as a base for all of our UI components. It's handy to be able to pass refs to components such as inputs or you need a DOM node's dimensions
In order to solve this problem, this pull request forwards refs for the Box and Text component.
More Information
Part of Adding
TextFieldBasecomponent #16043Pre-Merge Checklist
[ ] PR has been added to the appropriate release MilestoneN/A+ If there are functional changes:
[ ] "Extension QA Board" label has been appliedN/A