-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e test fixtures #16061
Merged
Merged
E2e test fixtures #16061
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
9bb3c12
remove state.json files
a01b109
move file
001c645
Update Readme
17e33a6
Create fixture builder
b05de59
load test fixture
430ac3e
remove redundant method
139177e
update snap tests
6911b75
update stats tests
8f5b1f7
update extension tests
4cea5a4
update extension tests
ea20e0c
Update fixture data
4ca9412
snap test dapp connection
68cd31c
Update fixture data
94fd0bf
add onboarding fixture
7ffd3bf
use onboarding fixture
368cf37
reuse import account vault
0713ade
remove unnecessary use of class
fe08920
use fixture builder in new tests
919ae4b
switch to function
a9bdabd
update default fixture
2421448
update default fixture
7ca43ca
update test
b7f2c5d
update 1559 test fixttures
440e455
update 1559 test fixtures
bef7208
update 1559 test fixtures
0eca839
dismiss 3box whats new
360e487
remove redundant code
165a4b0
move docs
3e87c44
remove unused code
5ffddaa
token detection
4fe7963
use default timeout
2451231
remove redundant code
9d84f8a
Update fixture builder
3b5fda3
add token to tokencontroller
2151515
remove network details
fb7de3a
add missing identities to preference controller
abeb5e8
remove duplicate properties
5caaf10
update bip-32 to use fixturebuilder
09004ff
alphabetise snap permissions
9e96ec2
update get snaps to use fixturebuilder
c77c8cc
Update test-snap-bip-32.spec.js
ce88224
add popular network state
5af2a41
update test
2327778
lint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 0 additions & 7 deletions
7
test/e2e/fixtures/README.md → docs/generating-fixture-data.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,22 +13,26 @@ const { | |
} = require('../helpers/file'); | ||
const { withFixtures, tinyDelayMs } = require('./helpers'); | ||
const { PAGES } = require('./webdriver/driver'); | ||
const FixtureBuilder = require('./fixture-builder'); | ||
|
||
const DEFAULT_NUM_SAMPLES = 20; | ||
const ALL_PAGES = Object.values(PAGES); | ||
|
||
async function measurePage(pageName) { | ||
let metrics; | ||
await withFixtures({ fixtures: 'imported-account' }, async ({ driver }) => { | ||
await driver.delay(tinyDelayMs); | ||
await driver.navigate(); | ||
await driver.fill('#password', 'correct horse battery staple'); | ||
await driver.press('#password', driver.Key.ENTER); | ||
await driver.findElement('.selected-account__name'); | ||
await driver.navigate(pageName); | ||
await driver.delay(1000); | ||
metrics = await driver.collectMetrics(); | ||
}); | ||
await withFixtures( | ||
{ fixtures: new FixtureBuilder().build() }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only the fixture has changed, the rest is just lint formatting |
||
async ({ driver }) => { | ||
await driver.delay(tinyDelayMs); | ||
await driver.navigate(); | ||
await driver.fill('#password', 'correct horse battery staple'); | ||
await driver.press('#password', driver.Key.ENTER); | ||
await driver.findElement('.selected-account__name'); | ||
await driver.navigate(pageName); | ||
await driver.delay(1000); | ||
metrics = await driver.collectMetrics(); | ||
}, | ||
); | ||
return metrics; | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the fixture has changed, the rest is just lint formatting