Fixes display of avatar in flex container #16047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
changed the title
Builds ready [e30f0d7]
Page Load Metrics (2107 ± 89 ms)
highlights: |
garrettbear
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the BaseAvatar breaks if the flex container is smaller than the children and will try to squeeze the avatar into the space available.
This is a problem because the BaseAvatar should always be the same ratio
In order to solve this problem, this pull request add flex property to the BaseAvatar to fix this
Screenshots/Screencaps
Before
avatar.broken.mov
After
avatar.fix.mov
Manual Testing Steps