Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aurora to the popular custom network list #16039

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

filipsekulic
Copy link
Contributor

Explanation

Added Aurora as the popular custom network.

More Information

Screenshots/Screencaps

Screencast.mov

Manual Testing Steps

  1. Go to Settings -> Experimental and enable Show custom network list
  2. Start the process of adding the popular custom network - Settings -> Networks -> Add a network or from the network dropdown (click on Add network)

@filipsekulic filipsekulic self-assigned this Sep 30, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@filipsekulic filipsekulic force-pushed the add-aurora-as-popular-network branch from 17195a3 to 954a269 Compare September 30, 2022 08:53
@metamaskbot
Copy link
Collaborator

Builds ready [954a269]
Page Load Metrics (2332 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90142110168
domContentLoaded19292565230214871
load19292565233216177
domInteractive19292565230214871

@mirjanaKukic
Copy link
Contributor

Verified by QA

@filipsekulic filipsekulic marked this pull request as ready for review September 30, 2022 13:31
@filipsekulic filipsekulic requested a review from a team as a code owner September 30, 2022 13:31
@filipsekulic filipsekulic requested a review from mcmire September 30, 2022 13:31
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified working and chain ID.

@metamaskbot
Copy link
Collaborator

Builds ready [25c2dfb]
Page Load Metrics (2306 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97138114115
domContentLoaded17502691228618689
load17502691230619895
domInteractive17502691228618689

@darkwing darkwing merged commit 02d7eb3 into develop Oct 3, 2022
@darkwing darkwing deleted the add-aurora-as-popular-network branch October 3, 2022 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Aurora to the popular network feature
7 participants