[FLASK] Fix transaction insight data display #16023

GuillaumeRx · 2022-09-28T16:19:55Z

Explanation

Fix display of transaction insight data by stringifying it.

github-actions · 2022-09-28T16:20:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/components/app/confirm-page-container/flask/snap-insight.js

metamaskbot · 2022-09-28T18:05:27Z

Builds ready [b053197]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2290 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	316	125	47	23
		domContentLoaded	2032	2644	2272	162	78
		load	2051	2644	2290	163	78
		domInteractive	2032	2644	2272	162	78

highlights:

storybook

metamaskbot · 2022-09-29T16:46:49Z

Builds ready [4091e85]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2335 ± 130 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	2133	220	440	211
		domContentLoaded	1895	3352	2301	280	135
		load	1895	3352	2335	271	130
		domInteractive	1895	3352	2301	280	135

highlights:

storybook

metamaskbot · 2022-10-03T13:33:51Z

Builds ready [a1bbde8]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2325 ± 126 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	2308	224	478	230
		domContentLoaded	1814	2953	2318	262	126
		load	1814	2953	2325	262	126
		domInteractive	1814	2953	2318	262	126

highlights:

storybook

metamaskbot · 2022-10-05T13:42:05Z

Builds ready [c3ebea7]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2538 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	238	129	32	15
		domContentLoaded	2205	2912	2516	163	78
		load	2206	2912	2538	164	79
		domInteractive	2205	2912	2516	163	78

highlights:

storybook

GuillaumeRx requested a review from a team as a code owner September 28, 2022 16:19

GuillaumeRx requested a review from jpuri September 28, 2022 16:19

ritave previously approved these changes Sep 28, 2022

View reviewed changes

Mrtenz reviewed Sep 28, 2022

View reviewed changes

ui/components/app/confirm-page-container/flask/snap-insight.js Outdated Show resolved Hide resolved

GuillaumeRx dismissed ritave’s stale review via 6ff8058 September 28, 2022 16:32

GuillaumeRx requested review from Mrtenz and ritave and removed request for jpuri September 28, 2022 17:05

GuillaumeRx force-pushed the gr/fix-insights-display branch from b053197 to 4091e85 Compare September 29, 2022 15:45

ritave previously approved these changes Sep 29, 2022

View reviewed changes

GuillaumeRx force-pushed the gr/fix-insights-display branch from 4091e85 to 22025b0 Compare September 30, 2022 12:32

brad-decker dismissed ritave’s stale review via 22025b0 September 30, 2022 14:10

GuillaumeRx force-pushed the gr/fix-insights-display branch from 22025b0 to a1bbde8 Compare September 30, 2022 16:17

GuillaumeRx requested a review from ritave October 3, 2022 13:17

ritave previously approved these changes Oct 3, 2022

View reviewed changes

GuillaumeRx force-pushed the gr/fix-insights-display branch from a1bbde8 to 42f667f Compare October 5, 2022 10:43

Mrtenz previously approved these changes Oct 5, 2022

View reviewed changes

FrederikBolding dismissed ritave’s stale review via 42f667f October 5, 2022 12:22

GuillaumeRx added 3 commits October 5, 2022 14:44

stringify content to display

b428ad7

check if data is a string to avoid stringifying it

6dc5ead

prettify JSON data

c3ebea7

GuillaumeRx force-pushed the gr/fix-insights-display branch from 42f667f to c3ebea7 Compare October 5, 2022 12:44

ritave approved these changes Oct 5, 2022

View reviewed changes

digiwand approved these changes Oct 5, 2022

View reviewed changes

jpuri dismissed Mrtenz’s stale review via c3ebea7 October 5, 2022 17:18

GuillaumeRx merged commit ca6701c into develop Oct 5, 2022

GuillaumeRx deleted the gr/fix-insights-display branch October 5, 2022 17:43

github-actions bot locked and limited conversation to collaborators Oct 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] Fix transaction insight data display #16023

[FLASK] Fix transaction insight data display #16023

GuillaumeRx commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

metamaskbot commented Sep 28, 2022

metamaskbot commented Sep 29, 2022

metamaskbot commented Oct 3, 2022

metamaskbot commented Oct 5, 2022

[FLASK] Fix transaction insight data display #16023

[FLASK] Fix transaction insight data display #16023

Conversation

GuillaumeRx commented Sep 28, 2022

Explanation

github-actions bot commented Sep 28, 2022

metamaskbot commented Sep 28, 2022

highlights:

metamaskbot commented Sep 29, 2022

highlights:

metamaskbot commented Oct 3, 2022

highlights:

metamaskbot commented Oct 5, 2022

highlights: