add e2e test for editing and deleting contact from address book #16014

mirjanaKukic · 2022-09-28T11:35:32Z

Explanation

Added new tests in address-book.spec.js file for editing and deleting contacts from address book

Resolves #13500

Manual Testing Steps

Run testcase locally or check ci pipeline and ensure that it continues to work normally:
yarn test:e2e:single test/e2e/tests/address-book.spec.js

Added tests are inside two it blocks:

Edit entry in address book
Adds an entry to address book and deletes it from address book

Pre-Merge Checklist

PR template is filled out
IF this PR fixes a bug, a test that would have caught the bug has been added
PR is linked to the appropriate GitHub issue
PR has been added to the appropriate release Milestone

+ If there are functional changes:

Manual testing complete & passed
"Extension QA Board" label has been applied

github-actions · 2022-09-28T11:35:46Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2022-09-28T13:07:05Z

Builds ready [3bee489]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2427 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	143	112	13	6
		domContentLoaded	1964	2705	2398	176	85
		load	1964	2706	2427	186	89
		domInteractive	1964	2705	2398	176	85

PeterYinusa · 2022-09-29T18:31:42Z

test/e2e/tests/address-book.spec.js

+
+        await driver.clickElement({ text: 'Edit', tag: 'button' });
+        const inputUsername = await driver.findElement('#nickname');
+        await inputUsername.clear();


I don't think we need to use the clear method, as the fill method that follows also clears the input under the hood.

PeterYinusa · 2022-09-29T18:32:09Z

test/e2e/tests/address-book.spec.js

+        // adding new account
+        await driver.clickElement({ text: 'Add contact', tag: 'button' });
+        const inputUsername = await driver.findElement('#nickname');
+        await inputUsername.clear();


same as above

seaona · 2022-09-30T06:51:13Z

test/e2e/tests/address-book.spec.js

+          '.send__select-recipient-wrapper__group-item',
+        );
+        assert.equal(contacts.length, 1);
+        // adding new account


Since we are using fixtures, I suggest to skip the part of adding a new contact, since it's already there. So we just test that the Delete function works, as the Add Contact function has already been tested on the first it block.

So you could remove from line 193 to line 206 and on line 208 look for Test Name 1 instead of Test Name 2

await driver.clickElement({ text: 'Test Name 1', tag: 'div' }); await driver.clickElement({ text: 'Edit', tag: 'button' }); await driver.clickElement({ text: 'Delete account', tag: 'a' }); // it checks if account is deleted // now there should be no contacts in the list so we can check that Element is not Present assert.equal(await driver.isElementPresent(...), false);

The it block could then be re-written something like Deletes existing entry from address book

metamaskbot · 2022-10-03T08:14:34Z

Builds ready [cdb4394]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2226 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	2218	215	460	221
		domContentLoaded	1832	2435	2201	153	73
		load	1832	2466	2226	163	78
		domInteractive	1832	2435	2201	153	73

metamaskbot · 2022-11-02T11:18:09Z

Builds ready [f56b659]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2183 ± 124 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	164	108	20	10
		domContentLoaded	1661	2831	2164	244	117
		load	1680	2913	2183	258	124
		domInteractive	1661	2831	2164	244	117

lint fix fix added fixture builder

metamaskbot · 2022-11-02T13:05:47Z

Builds ready [940ef46]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2140 ± 122 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	2403	237	498	239
		domContentLoaded	1680	2541	2131	255	122
		load	1680	2541	2140	255	122
		domInteractive	1680	2541	2131	255	122

seaona

LGTM

mirjanaKukic added PS-team PS MM extension team issues needs-qa Label will automate into QA workspace labels Sep 28, 2022

mirjanaKukic self-assigned this Sep 28, 2022

PeterYinusa reviewed Sep 29, 2022

View reviewed changes

PeterYinusa previously approved these changes Sep 29, 2022

View reviewed changes

seaona reviewed Sep 30, 2022

View reviewed changes

mirjanaKukic dismissed PeterYinusa’s stale review via 209ad3c September 30, 2022 09:19

mirjanaKukic force-pushed the e2e/editing-deleting-contact branch from 209ad3c to faa3fdd Compare September 30, 2022 14:31

mirjanaKukic marked this pull request as ready for review September 30, 2022 14:31

mirjanaKukic requested a review from a team as a code owner September 30, 2022 14:31

mirjanaKukic requested a review from garrettbear September 30, 2022 14:31

mirjanaKukic force-pushed the e2e/editing-deleting-contact branch from faa3fdd to cdb4394 Compare October 3, 2022 07:13

seaona previously approved these changes Oct 6, 2022

View reviewed changes

PeterYinusa previously approved these changes Oct 6, 2022

View reviewed changes

mirjanaKukic dismissed stale reviews from PeterYinusa and seaona via df1ef24 November 2, 2022 10:03

mirjanaKukic force-pushed the e2e/editing-deleting-contact branch from cdb4394 to df1ef24 Compare November 2, 2022 10:03

mirjanaKukic force-pushed the e2e/editing-deleting-contact branch from f56b659 to 940ef46 Compare November 2, 2022 12:11

added new tests for editing and deleting contact from address book

940ef46

lint fix fix added fixture builder

PeterYinusa approved these changes Nov 2, 2022

View reviewed changes

seaona approved these changes Nov 2, 2022

View reviewed changes

PeterYinusa merged commit 95dcf07 into develop Nov 2, 2022

PeterYinusa deleted the e2e/editing-deleting-contact branch November 2, 2022 14:28

github-actions bot locked and limited conversation to collaborators Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add e2e test for editing and deleting contact from address book #16014

add e2e test for editing and deleting contact from address book #16014

mirjanaKukic commented Sep 28, 2022

github-actions bot commented Sep 28, 2022

metamaskbot commented Sep 28, 2022

PeterYinusa Sep 29, 2022 •

edited

Loading

mirjanaKukic Sep 30, 2022

PeterYinusa Sep 29, 2022

mirjanaKukic Sep 30, 2022

seaona Sep 30, 2022 •

edited

Loading

mirjanaKukic Sep 30, 2022

seaona Oct 6, 2022

metamaskbot commented Oct 3, 2022

metamaskbot commented Nov 2, 2022

metamaskbot commented Nov 2, 2022

seaona left a comment

add e2e test for editing and deleting contact from address book #16014

add e2e test for editing and deleting contact from address book #16014

Conversation

mirjanaKukic commented Sep 28, 2022

Explanation

Manual Testing Steps

Pre-Merge Checklist

+ If there are functional changes:

github-actions bot commented Sep 28, 2022

metamaskbot commented Sep 28, 2022

PeterYinusa Sep 29, 2022 • edited Loading

Choose a reason for hiding this comment

mirjanaKukic Sep 30, 2022

Choose a reason for hiding this comment

PeterYinusa Sep 29, 2022

Choose a reason for hiding this comment

mirjanaKukic Sep 30, 2022

Choose a reason for hiding this comment

seaona Sep 30, 2022 • edited Loading

Choose a reason for hiding this comment

mirjanaKukic Sep 30, 2022

Choose a reason for hiding this comment

seaona Oct 6, 2022

Choose a reason for hiding this comment

metamaskbot commented Oct 3, 2022

metamaskbot commented Nov 2, 2022

metamaskbot commented Nov 2, 2022

seaona left a comment

Choose a reason for hiding this comment

PeterYinusa Sep 29, 2022 •

edited

Loading

seaona Sep 30, 2022 •

edited

Loading