Replace setInterval with chrome alarms for MetaMetrics FinalizeEventFragment #16003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NiranjanaBinoy
added
the
PR - P1
brad-decker
previously approved these changes
Sep 28, 2022
darkwing
requested changes
Sep 28, 2022
| ); | ||
|
|
||
| if (hasAlarm) { | ||
| Object.values(this.store.getState().fragments).forEach( |
There was a problem hiding this comment.
Can we make this Object.values.forEach block a helper function? It looks duplicated here and within the setTimeout
There was a problem hiding this comment.
@NiranjanaBinoy we could make a 'finalizeAbandonedFragments' method that does this.
Builds ready [c8b3f43]
Page Load Metrics (2226 ± 65 ms)
highlights:storybook
|
Builds ready [0e7be61]
Page Load Metrics (2415 ± 69 ms)
highlights:storybook
|
darkwing
approved these changes
Oct 3, 2022
brad-decker
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We are replacing setInterval with chrome alarm to schedule the call to
FinalizeEventFragment()every 1 min. The current interval window for FinalizeEventFragment() is 30 sec; we are updating that to 1 min since chrome alarms require the interval to be at least 1 mins and replace setInterval with chrome alarms.More Information
Fixes #15933
Screenshots/Screencaps
Before
After
Manual Testing Steps
chrome.alarm.onalarm.addListener()and insidegetall()to verify the alarm is getting triggered at 1 mins interval.Pre-Merge Checklist
+ If there are functional changes: