Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio site e2e #15921

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Portfolio site e2e #15921

merged 5 commits into from
Sep 22, 2022

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Sep 21, 2022

Explanation

Fixes: #15850

Add's an e2e test to ensure the portfolio site is configured correctly

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa added the needs-qa Label will automate into QA workspace label Sep 21, 2022
@PeterYinusa PeterYinusa marked this pull request as ready for review September 21, 2022 13:57
@PeterYinusa PeterYinusa requested a review from a team as a code owner September 21, 2022 13:57
@metamaskbot
Copy link
Collaborator

Builds ready [4d426ff]
Page Load Metrics (1349 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871578185320154
domContentLoaded11711579132510450
load11761579134910249
domInteractive11711579132510450

@metamaskbot
Copy link
Collaborator

Builds ready [4d426ff]
Page Load Metrics (1349 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871578185320154
domContentLoaded11711579132510450
load11761579134910249
domInteractive11711579132510450

@metamaskbot
Copy link
Collaborator

Builds ready [23bbbe0]
Page Load Metrics (1248 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint843011184823
domContentLoaded1115152312269546
load1130152312489144
domInteractive1115152312269546

Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterYinusa PeterYinusa merged commit 1370f19 into develop Sep 22, 2022
@PeterYinusa PeterYinusa deleted the portfolio-site-e2e branch September 22, 2022 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Label will automate into QA workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for portfolio
5 participants