Update address component on transaction data screen #15888

amerkadicE · 2022-09-20T12:01:55Z

Explanation

This pull request will update the current logic for a recipient address on the transaction data screen.
Now it will show

If the address exists in the user account list, then the account name is displayed
If the address exists in the user address book (contacts), then their nickname is displayed
If the address exists in the contract metadata list, then the contract's name is displayed
If conditionals from before are not met, it will show the user address.

Also, clicking on this component opens the 'add/edit nickname' popup or this tooltip if it's one of the user's accounts.

After checking the code, we found out that this PR will also update the logic on the recipient address when sending funds as shown in screenshot below.

More Information

Fixes #15780

Screenshots/Screencaps

Before

After

Send screen

Manual Testing Steps

Pre-Merge Checklist

PR template is filled out
IF this PR fixes a bug, a test that would have caught the bug has been added
PR is linked to the appropriate GitHub issue
PR has been added to the appropriate release Milestone

+ If there are functional changes:

Manual testing complete & passed
"Extension QA Board" label has been applied

github-actions · 2022-09-20T12:02:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2022-09-21T09:35:39Z

Builds ready [36914f0]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1324 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	244	111	32	16
		domContentLoaded	1168	1721	1316	144	69
		load	1168	1721	1324	141	68
		domInteractive	1168	1720	1316	144	69

highlights:

storybook

E2E test fix Fix tests

metamaskbot · 2022-09-22T12:18:59Z

Builds ready [9ce516c]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1360 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	1272	167	254	122
		domContentLoaded	1214	1551	1345	91	44
		load	1214	1551	1360	98	47
		domInteractive	1214	1551	1345	91	44

highlights:

storybook

metamaskbot · 2022-09-23T14:32:00Z

Builds ready [678bdad]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1261 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	1310	227	349	168
		domContentLoaded	1135	1440	1252	81	39
		load	1135	1468	1261	88	42
		domInteractive	1135	1440	1252	81	39

highlights:

storybook

mirjanaKukic · 2022-09-26T11:40:28Z

Verified by QA

…ata-screen

metamaskbot · 2022-11-07T19:28:43Z

Builds ready [74bd53f]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2271 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	2307	416	737	354
		domContentLoaded	1836	2517	2239	156	75
		load	1941	2646	2271	153	74
		domInteractive	1836	2517	2239	156	75

highlights:

storybook

amerkadicE force-pushed the update-address-component-on-transaction-data-screen branch from 36914f0 to 41174c7 Compare September 22, 2022 11:21

Update address component on transaction data screen

9ce516c

E2E test fix Fix tests

amerkadicE force-pushed the update-address-component-on-transaction-data-screen branch from 41174c7 to 9ce516c Compare September 22, 2022 11:23

amerkadicE added 2 commits September 23, 2022 15:23

Metadata accounts

9399321

Remove test resulsts

678bdad

amerkadicE marked this pull request as ready for review September 27, 2022 06:33

amerkadicE requested a review from a team as a code owner September 27, 2022 06:33

amerkadicE requested a review from mcmire September 27, 2022 06:33

brad-decker approved these changes Sep 28, 2022

View reviewed changes

bschorchit mentioned this pull request Nov 4, 2022

Replaced addresses by the address component on SignTypedData v4 signatures #16018

Merged

Merge branch 'develop' into update-address-component-on-transaction-d…

74bd53f

…ata-screen

jpuri approved these changes Nov 8, 2022

View reviewed changes

amerkadicE merged commit d4ffc3a into develop Nov 8, 2022

amerkadicE deleted the update-address-component-on-transaction-data-screen branch November 8, 2022 08:34

github-actions bot locked and limited conversation to collaborators Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update address component on transaction data screen #15888

Update address component on transaction data screen #15888

amerkadicE commented Sep 20, 2022 •

edited

Loading

github-actions bot commented Sep 20, 2022

metamaskbot commented Sep 21, 2022

metamaskbot commented Sep 22, 2022

metamaskbot commented Sep 23, 2022

mirjanaKukic commented Sep 26, 2022

metamaskbot commented Nov 7, 2022

Update address component on transaction data screen #15888

Update address component on transaction data screen #15888

Conversation

amerkadicE commented Sep 20, 2022 • edited Loading

Explanation

More Information

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-Merge Checklist

+ If there are functional changes:

github-actions bot commented Sep 20, 2022

metamaskbot commented Sep 21, 2022

highlights:

metamaskbot commented Sep 22, 2022

highlights:

metamaskbot commented Sep 23, 2022

highlights:

mirjanaKukic commented Sep 26, 2022

metamaskbot commented Nov 7, 2022

highlights:

amerkadicE commented Sep 20, 2022 •

edited

Loading