Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct base asset in Decrypt Request view #15885

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Show correct base asset in Decrypt Request view #15885

merged 1 commit into from
Sep 20, 2022

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 20, 2022

Fixes: #15866

Test Plan

Defined in issue

On Polygon:
Screen Shot 2022-09-19 at 10 37 31 PM

Screen Shot 2022-09-19 at 10 38 00 PM

On ETH net (Rinkeby):
Screen Shot 2022-09-19 at 10 38 42 PM

@ryanml ryanml self-assigned this Sep 20, 2022
@ryanml ryanml requested a review from a team as a code owner September 20, 2022 05:44
@ryanml ryanml requested a review from digiwand September 20, 2022 05:45
@metamaskbot
Copy link
Collaborator

Builds ready [1875bc5]
Page Load Metrics (1403 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint981455247369177
domContentLoaded12231633139512560
load12241633140312058
domInteractive12231633139512560

@ryanml ryanml merged commit e422c6b into develop Sep 20, 2022
@ryanml ryanml deleted the fix-15866 branch September 20, 2022 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Decrypt request page displays always ETH token, no matter in which network
4 participants