Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ether from a faucet - fix message #15875

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Get ether from a faucet - fix message #15875

merged 2 commits into from
Sep 19, 2022

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 19, 2022

Explanation

On the Buy prompt for test networks, we see an unfinished message saying Get Ether from a faucet for the $Network. This PR adds the end of the sentence and a full stop.

Screenshots/Screencaps

Before

get-ether-from-faucet-before

After

get-ether-from-faucet-after

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@seaona seaona requested a review from a team as a code owner September 19, 2022 11:50
@seaona seaona requested a review from PeterYinusa September 19, 2022 11:50
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e8d9976]
Page Load Metrics (1555 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96163130189
domContentLoaded12861846153514167
load13131846155514369
domInteractive12861846153514167

highlights:

storybook

@metamaskbot
Copy link
Collaborator

Builds ready [4592028]
Page Load Metrics (1304 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852211122813
domContentLoaded11591509129010751
load11591509130410551
domInteractive11591508129010751

highlights:

storybook

@seaona seaona merged commit 9e1cbe2 into develop Sep 19, 2022
@seaona seaona deleted the messages-faucet-fix branch September 19, 2022 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants