Created the NFT component for single NFT allowance #15825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Verified by QA |
brad-decker
suggested changes
Sep 14, 2022
| textAlign={TEXT_ALIGN.END} | ||
| marginTop={4} | ||
| marginRight={4} | ||
| className="nft-info__content__view" |
There was a problem hiding this comment.
BEM class syntax doesn't allow for nesting blocks this way, if you need a block within another block then it should be named like nft-info__content-view
There was a problem hiding this comment.
Hi @brad-decker , You can see changes here
adnansahovic
force-pushed
the
NFT-component-for-single-NFT-allowance
branch
from
fd801cb to
a8832a5
Compare
Builds ready [a8832a5]
Page Load Metrics (1221 ± 16 ms)
highlights:storybook
|
brad-decker
previously approved these changes
Sep 15, 2022
adnansahovic
force-pushed
the
NFT-component-for-single-NFT-allowance
branch
from
a8832a5 to
b19e5dd
Compare
Builds ready [b19e5dd]
Page Load Metrics (2376 ± 88 ms)
highlights:storybook
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Created the NFT component for single NFT allowance. This component can't yet be added to the app. Instead, I added a storybook that displays this component.
More Information
Screenshots/Screencaps
Manual Testing Steps
This component can be tested by running storybook (yarn storybook) and then go to the COMPONENTS tab and open in UI/NftInfo.