Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v10.16.1 RC #15067

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Version v10.16.1 RC #15067

merged 5 commits into from
Jun 28, 2022

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

metamaskbot and others added 2 commits June 28, 2022 14:42
@metamaskbot
Version v10.16.1
51311e4
@danjm @FrederikBolding
Ensure that addresses are properly hex-prefixed in the generate ERC t…
7f9e24c 
…oken transfer functions (#15064)

* Ensure that addresses are properly hex-prefixed in the generate ERC token transfer functions

* Ensure hex-prefixed addresses in send input

* Update unit tests

Co-authored-by: Frederik Bolding <[email protected]>
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm marked this pull request as ready for review June 28, 2022 16:58
@danjm danjm requested a review from a team as a code owner June 28, 2022 16:58
@danjm danjm requested a review from ryanml June 28, 2022 16:58
Gudahtt
Gudahtt reviewed Jun 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt reviewed Jun 28, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
Gudahtt
Gudahtt approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt reviewed Jun 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test requires another update it looks like, due to the same conflicts you handled already in landing it on develop

Gudahtt
Gudahtt previously approved these changes Jun 28, 2022
View reviewed changes
@Gudahtt Gudahtt force-pushed the Version-v10.16.1 branch from 8c57ab2 to 52590b8 Compare June 28, 2022 17:48
Gudahtt
Gudahtt previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cleaned up the commit history a bit and added a link to the revert PR

@seaona
Copy link
Contributor

seaona commented Jun 28, 2022

Fix is working good, but pasting ENS addresses is now broken (see left side of the video, compared to right side on v10.15.1):

cannot-paste-ens-address.mp4

Atandanny
Atandanny previously approved these changes Jun 28, 2022
View reviewed changes
@danjm danjm mentioned this pull request Jun 28, 2022
Merged
@metamaskbot
Copy link
Collaborator Author

Builds ready [52590b8]
Page Load Metrics (1969 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951828212371178
domContentLoaded17132317195017082
load17192379196918388
domInteractive17132317195017081

highlights:

storybook

@danjm danjm dismissed stale reviews from Atandanny and Gudahtt via 05f29ed June 28, 2022 19:40
@metamaskbot
Copy link
Collaborator Author

Builds ready [05f29ed]
Page Load Metrics (1787 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint79132105147
domContentLoaded15932095176311656
load16302196178712359
domInteractive15932095176311656

highlights:

storybook

@danjm danjm merged commit 1b9130d into master Jun 28, 2022
@danjm danjm deleted the Version-v10.16.1 branch June 28, 2022 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm left review comments

@PeterYinusa PeterYinusa PeterYinusa approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@Atandanny Atandanny Atandanny left review comments

@ryanml ryanml Awaiting requested review from ryanml ryanml was automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@metamaskbot @seaona @Gudahtt @danjm @PeterYinusa @Atandanny