Hardware wallet copy updates, referral and tutorial buttons #14738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
owencraston
reviewed
May 18, 2022
| <Button | ||
| className="hw-connect__external-btn" | ||
| type="secondary" | ||
| onClick={() => window.open("https://support.ledger.com/hc/en-us/articles/4404366864657-Set-up-and-use-MetaMask-to-access-your-Ledger-Ethereum-ETH-account?docs=true", "_blank") |
There was a problem hiding this comment.
This link should probably be a const so that if it changes we can just change that one variable.
There was a problem hiding this comment.
Good point, I'm not sure how to do this though to be honest. Previously all the links in this page were just added similar to this so I'm also not sure what the correct practice is here.
owencraston
reviewed
May 18, 2022
| <Button | ||
| className="hw-connect__external-btn-first" | ||
| type="secondary" | ||
| onClick={() => window.open("https://gridplus.io/?afmc=7p", "_blank") |
There was a problem hiding this comment.
same as above. Also what does the _blank do?
There was a problem hiding this comment.
_blank should open in a new tab
|
Awesome stuff Alex! |
segun
reviewed
May 19, 2022
…//github.com/MetaMask/metamask-extension into hardware-wallets-referral-and-tutorial-links
…https://github.com/MetaMask/metamask-extension into hardware-wallets-referral-and-tutorial-links" This reverts commit 416abd7, reversing changes made to d511ae1.
…links' of https://github.com/MetaMask/metamask-extension into hardware-wallets-referral-and-tutorial-links"" This reverts commit 597a908.
|
The only changes that are relevant here are those in All those other changes are because I kept having local build problems with various permutations of #14451 and #10748 (even though I'm on MacOS) being noticed. I attempted to fix but failed so I can't run this on my local machine right now. |
…eferral-and-tutorial-links
|
@segun @owencraston this is ready for another pass, thanks! |
segun
approved these changes
Oct 3, 2022
Builds ready [a7c2b82]
Page Load Metrics (2325 ± 93 ms)
highlights:storybook
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We need to start adding referral links to our hardware wallet partners, whilst we're doing this we may as well update our tutorial links as well (some of them were super old and broken). I've also included a number of minor copy changes.
More Information
I proposed this in Slack and various stakeholders agreed with this approach: https://consensys.slack.com/archives/C026NDN79JB/p1652271544204939
Screenshots/Screencaps
Before
Old.Hardware.Wallet.Tutorials.mov
After
Hardware.Wallet.Buttons.Screencapture.mov
Manual Testing Steps
Go to the "Connect Hardware Wallet" screen to click each hardware wallet section to see all the copy changes and buttons.
Pre-Merge Checklist