Remove 3box feature and delete ThreeBoxController #14571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 |
darkwing
previously requested changes
May 2, 2022
brad-decker
previously approved these changes
May 2, 2022
|
We need a deprecation plan before we can merge this, including messaging to any existing users |
|
Marking is |
Closed
|
@Gudahtt i would claim that we dont need a migration path bc the feature was only ever experimental. i agree that informing users that had it enabled is worth blocking on. |
6 tasks
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mobularay
added this to the Milestone 1: Dev build ready at the end of Q3, Sep 30, 2022 milestone
6 tasks
|
This resolves #10608 |
Lint locale messages lavamoat policy updates
The 3Box user trait has been restored and hard-coded as `false`. This ensures that users don't get stuck in our metrics as having this trait. A deprecation comment has been left in various places for this trait.
legobeat
reviewed
Oct 31, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
dismissed
darkwing’s stale review
An in-app deprecation warning has been in place for some time now, and warned of this feature being deprecated in "early October"
Builds ready [d47f42c]
Page Load Metrics (2300 ± 162 ms)
highlights:storybook
|
Gtonizuka
approved these changes
Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the 3box sync feature and deletes the
ThreeBoxController. Adds a migration to ensure that theThreeBoxControlleris removed from persisted state.This shaves 600kb or 3.2% from our bundle (18.5mb -> 17.9mb).