-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing design tokens and writing docs in storybook #13657
Installing design tokens and writing docs in storybook #13657
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [61c2303]Page Load Metrics (1150 ± 28 ms)
highlights:storybook
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ___ ⭐ This is looking awesome! I have some optional suggestions and thoughts. No blockers.
I wonder if it would be helpful to mirror this content in the @metamask/design-tokens
repo
a6b4fbd
to
bfbb6d6
Compare
Builds ready [bfbb6d6]Page Load Metrics (1127 ± 23 ms)
highlights:storybook
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGreatTM! Thanks for addressing all of my thoughts and NITs :)
Fixes: #13564
Explanation: Installing
@metamask/design-tokens
repo and adding guidelines on how to use colors.token.json
from the design-tokens repo.Manual testing steps:
OR
yarn setup && yarn storybook
Screenshots
CSS variables available to use in styles
Color Documentation