Dark Theme setup and button theming #13651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Waiting on MetaMask/design-tokens#22 to be merged and deployed to continue on button theming |
darkwing
changed the title
Builds ready [216fdd6]Page Load Metrics (1230 ± 46 ms)
highlights:storybook
|
Builds ready [d48ceb5]Page Load Metrics (1174 ± 40 ms)
highlights:storybook
|
GuillaumeRx
force-pushed
the
dark-theme-setup
branch
from
7ffc9b4 to
09f4237
Compare
Builds ready [09f4237]Page Load Metrics (1195 ± 59 ms)
highlights:storybook
|
|
omg i love this so much. |
brad-decker
previously approved these changes
Feb 22, 2022
Builds ready [80bec7d]Page Load Metrics (1206 ± 134 ms)
highlights:storybook
|
Closed
GuillaumeRx
force-pushed
the
dark-theme-setup
branch
from
80bec7d to
d108bb9
Compare
|
Seeing this on the home screen: Hover.mp4 |
@darkwing oh yes good catch, we don't have a darker in between that matches the original hover color. @georgewrmarshall what's you thoughts about this ? |
|
This issue is also happening on the "Settings" > "About" screen on |
Builds ready [8f30b3a]Page Load Metrics (1144 ± 47 ms)
highlights:storybook
|
There was a problem hiding this comment.
Looking good. I've added some of my suggestions to a branch that I've created a PR into this branch for #13742
Closed
georgewrmarshall
added a commit
that referenced
this pull request
Feb 24, 2022
… use implementation in #13651
georgewrmarshall
previously approved these changes
Feb 24, 2022
georgewrmarshall
added a commit
that referenced
this pull request
Feb 25, 2022
… use implementation in #13651
2 tasks
darkwing
previously approved these changes
Feb 25, 2022
* Updating some styles and removing some deprecated buttons * Warning button fixes * Fixing warning text for darkmode
GuillaumeRx
dismissed stale reviews from darkwing and georgewrmarshall
via
405bcff
GuillaumeRx
force-pushed
the
dark-theme-setup
branch
from
06b6e58 to
405bcff
Compare
darkwing
approved these changes
Feb 25, 2022
Builds ready [405bcff]Page Load Metrics (1286 ± 69 ms)
highlights:storybook
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Add
@metamask/design-tokensthat includes dark theme color variables and apply it on the button component