Prevent automatic rejection of confirmations #13194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
prevent-confirmation-rejection-from-automatic-closes
branch
3 times, most recently
from
b5a30c2 to
654b174
Compare
|
|
Gudahtt
force-pushed
the
prevent-confirmation-rejection-from-automatic-closes
branch
2 times, most recently
from
431047f to
0701bc5
Compare
Confirmations are now only automatically rejected if a user explicitly closes the notification window. If we close the window programmatically because there are no notifications left to show, nothing gets rejected. This partially avoids a race condition where a confirmation gets rejected automatically without the user having seen the confirmation first. This could happen if the confirmation was processed just as the notification window was being closed. It's still possible for a confirmation that the user has never seen to get rejected as a result of the user closing the window. But at least now it's no longer possible for a confirmation to get rejected in this manner after the user resolves the last confirmation in the queue.
Gudahtt
force-pushed
the
prevent-confirmation-rejection-from-automatic-closes
branch
from
0701bc5 to
83fe26d
Compare
rekmarks
reviewed
Jan 4, 2022
Builds ready [83fe26d]Page Load Metrics (1186 ± 48 ms)
highlights:storybook
|
All windows were being detected as explicit window closures, essentially just as they were previously, because this variable was cleared too soon.
After the window is automatically closed, a confirmation may have been queued up while the window was closing. If so, the popup is now re- opened.
|
When testing this with the I've updated this branch to automatically re-trigger the UI in this circumstance as well. The PR description has been updated accordingly:
|
Builds ready [3198d31]Page Load Metrics (1121 ± 52 ms)
highlights:storybook
|
ritave
approved these changes
Jan 5, 2022
Gudahtt
deleted the
prevent-confirmation-rejection-from-automatic-closes
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmations are now only automatically rejected if a user explicitly closes the notification window. If we close the window programmatically because there are no notifications left to show, nothing gets rejected.
This partially avoids a race condition where a confirmation gets rejected automatically without the user having seen the confirmation first. This could happen if the confirmation was processed just as the notification window was being closed.
It's still possible for a confirmation that the user has never seen to get rejected as a result of the user closing the window. But at least now it's no longer possible for a confirmation to get rejected in this manner after the user resolves the last confirmation in the queue.
If there is a queued confirmation when the popup is automatically closed, the popup is triggered again so that the user is presented with it.