Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Fix typo in locale key #13186

Merged
merged 6 commits into from
Sep 22, 2022
Merged

[i18n] Fix typo in locale key #13186

merged 6 commits into from
Sep 22, 2022

Conversation

bengeois
Copy link
Contributor

@bengeois bengeois commented Dec 31, 2021 •
edited
Loading

Explanation:

  • fix 1 message typo in edit-gas-fee-popover.js

@bengeois bengeois requested a review from a team as a code owner December 31, 2021 08:58
@bengeois bengeois requested a review from jpuri December 31, 2021 08:58
@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2021 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bengeois
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mcmire
Copy link
Contributor

mcmire commented Jan 6, 2022

Hey, thanks for the PR. We have a lot of new translations coming in via #13206, so I'll wait until that's merged first before looking at this.

@mcmire mcmire added blocked area-translation Issues relating to translating the app into various languages. labels Jan 6, 2022
@kumavis kumavis removed the blocked label Jul 30, 2022
@kumavis kumavis changed the title Sync and update french translation [i18n:fr] Sync and update french translation Jul 30, 2022
@brad-decker
Copy link
Contributor

@benjaminbrgs could you rebase this PR now and we'll get it reviewed. Thank you!

@bengeois bengeois changed the title [i18n:fr] Sync and update french translation [WIP] [i18n:fr] Sync and update french translation Sep 22, 2022
@bengeois bengeois changed the title [WIP] [i18n:fr] Sync and update french translation [i18n] Fix typo in locale key Sep 22, 2022
@bengeois
Copy link
Contributor Author

@brad-decker This PR is now rebased.
I change the title as there is no more translation in this PR. All of them were made by #13206

@brad-decker brad-decker merged commit 6638e53 into MetaMask:develop Sep 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
@brad-decker
Copy link
Contributor

Thanks for your contribution @benjaminbrgs!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@brad-decker brad-decker brad-decker approved these changes

@jpuri jpuri Awaiting requested review from jpuri jpuri is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
area-translation Issues relating to translating the app into various languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bengeois @mcmire @brad-decker @digiwand @kumavis